Thread (25 messages) 25 messages, 9 authors, 2020-11-10

Re: [PATCH net-next 10/11] ch_ktls: fix enum-conversion warning

From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-10-26 21:42:29
Also in: lkml

On Mon, Oct 26, 2020 at 10:29:57PM +0100, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@arndb.de>

gcc points out an incorrect enum assignment:

drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c: In function 'chcr_ktls_cpl_set_tcb_rpl':
drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c:684:22: warning: implicit conversion from 'enum <anonymous>' to 'enum ch_ktls_open_state' [-Wenum-conversion]

This appears harmless, and should apparently use 'CH_KTLS_OPEN_SUCCESS'
instead of 'false', with the same value '0'.

Fixes: efca3878a5fb ("ch_ktls: Issue if connection offload fails")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd

I have the same fix in my tree of W=1 fixes. I was just waiting for
net-next to open.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help