Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

On Fri, Oct 2, 2020 at 6:42 PM Stephen Hemminger
[off-list ref] wrote:

On Fri, 2 Oct 2020 16:23:46 -0400
Jarod Wilson [off-list ref] wrote:

quoted

On Fri, Oct 2, 2020 at 3:13 PM Stephen Hemminger
[off-list ref] wrote:

quoted

On Fri,  2 Oct 2020 13:40:01 -0400
Jarod Wilson [off-list ref] wrote:

quoted

By default, enable retaining all user-facing API that includes the use of
master and slave, but add a Kconfig knob that allows those that wish to
remove it entirely do so in one shot.

...

quoted

quoted

This is problematic. You are printing both old and new values.
Also every distribution will have to enable it.

This looks like too much of change to users.

I'd had a bit of feedback that people would rather see both, and be
able to toggle off the old ones, rather than only having one or the
other, depending on the toggle, so I thought I'd give this a try. I
kind of liked the one or the other route, but I see the problems with
that too.

For simplicity, I'm kind of liking the idea of just not updating the
proc and sysfs interfaces, have a toggle entirely disable them, and
work on enhancing userspace to only use netlink, but ... it's going to
be a while before any such work makes its way to any already shipping
distros. I don't have a satisfying answer here.

I like the idea of having bonding proc and sysf apis optional.

I do too, but I'd see it more as something only userspace developers
would care about for a while, as an easy way to make absolutely
certain their code/distro is no longer reliant on them and only uses
netlink, not as something any normal user really has any reason to do.

-- 
Jarod Wilson
jarod@redhat.com