Thread (23 messages) 23 messages, 6 authors, 2020-10-05

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

flat view

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2020-10-02 19:13:23
Also in: lkml

On Fri,  2 Oct 2020 13:40:01 -0400
Jarod Wilson [off-list ref] wrote:
By default, enable retaining all user-facing API that includes the use of
master and slave, but add a Kconfig knob that allows those that wish to
remove it entirely do so in one shot.

Cc: Jay Vosburgh <redacted>
Cc: Veaceslav Falico <redacted>
Cc: Andy Gospodarek <andy@greyhouse.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Thomas Davis <redacted>
Cc: <redacted>
Signed-off-by: Jarod Wilson <redacted>
---
 drivers/net/Kconfig                   | 12 ++++++++++++
 drivers/net/bonding/bond_main.c       |  4 ++--
 drivers/net/bonding/bond_options.c    |  4 ++--
 drivers/net/bonding/bond_procfs.c     |  8 ++++++++
 drivers/net/bonding/bond_sysfs.c      | 14 ++++++++++----
 drivers/net/bonding/bond_sysfs_port.c |  6 ++++--
 6 files changed, 38 insertions(+), 10 deletions(-)
This is problematic. You are printing both old and new values.
Also every distribution will have to enable it.

This looks like too much of change to users.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help