On Sun, Oct 11, 2020 at 2:59 PM Jakub Kicinski [off-list ref] wrote:

On Sun, 11 Oct 2020 06:23:00 -0400 Michael Chan wrote:

quoted

+static int bnxt_dl_info_put(struct bnxt *bp, struct devlink_info_req *req,
+                         enum bnxt_dl_version_type type, const char *key,
+                         char *buf)
+{
+     if (!strlen(buf))
+             return 0;

I think buf can be directly read from FW in later patches, it'd be good
to see a strnlen(), or bnxt_hwrm_nvm_get_dev_info() ensuring strings
are null-terminated.

Our fw interface spec specifies a NULL terminated string to be
returned by firmware.  But we can probably add an additional check
when we process the firmware response.