Re: [PATCH net-next 3/9] bnxt_en: Set driver default message level.
From: Michael Chan <michael.chan@broadcom.com>
Date: 2020-10-11 22:18:21
Attachments
- smime.p7s [application/pkcs7-signature] 4166 bytes
From: Michael Chan <michael.chan@broadcom.com>
Date: 2020-10-11 22:18:21
On Sun, Oct 11, 2020 at 2:53 PM Jakub Kicinski [off-list ref] wrote:
I'm talking about bnxt_dbg_dump_states specifically.
I'm looking at net-next:
bnxt_rx_pkt
bnxt_sched_reset
set_bit(BNXT_RESET_TASK_SP_EVENT, &bp->sp_event);
bnxt_sp_task
bnxt_reset
bnxt_reset_task
bnxt_dbg_dump_statesYes, you are right. Although, we actually go through a slightly different path with a different event when we encounter these RX buffer errors: bnxt_sched_reset() set_bit(BNXT_RST_RING_SP_EVENT, &bp->sp_event) bnxt_rx_ring_reset() bnxt_hwrm_rx_ring_reset() But with the oldest firmware, this call would fail and we would fall back to bnxt_reset_task() with non-silent mode. I will respin and change this call to silent mode. Thanks.