Re: [PATCH bpf-next] samples: bpf: refactor xdp_sample_pkts_kern with BTF-defined map

On Mon, Sep 7, 2020 at 10:02 PM Michal Rostecki [off-list ref] wrote:

Daniel T. Lee writes:

quoted

Most of the samples were converted to use the new BTF-defined MAP as
they moved to libbbpf, but some of the samples were missing.

Instead of using the previous BPF MAP definition, this commit refactors
xdp_sample_pkts_kern MAP definition with the new BTF-defined MAP format.

Signed-off-by: Daniel T. Lee <redacted>
---
 samples/bpf/xdp_sample_pkts_kern.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

I see that samples/bpf/ibumad_kern.c and samples/bpf/xdp_monitor_kern.c
still have old style BPF map definitions. Maybe you could change them as
well?

Thanks for the review!

Actually, I'm well aware that there are some samples left with old style map
definitions, But those examples should be transferred from bpf_load to
libbbpf, not just bpf map changes.

I'm also planning to refactor those patches in the future.
For now I've just refactored this file, but if you think this patch
size is small,
I'll send it with other changes.