Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: 2020-09-10 21:52:52
Also in:
linux-leds, lkml
On Thu, Sep 10, 2020 at 10:31:12PM +0200, Marek Behun wrote:
On Thu, 10 Sep 2020 19:34:35 +0100 Russell King - ARM Linux admin [off-list ref] wrote:quoted
On Thu, Sep 10, 2020 at 08:31:54PM +0200, Andrew Lunn wrote:quoted
Generally the driver will default to the hardware reset blink pattern. There are a few PHY drivers which change this at probe, but not many. The silicon defaults are pretty good.The "right" blink pattern can be a matter of how the hardware is wired. For example, if you have bi-colour LEDs and the PHY supports special bi-colour mixing modes.Have you seen such, Russell? This could be achieved via the multicolor LED framework, but I don't have a device which uses such LEDs, so I did not write support for this in the Marvell PHY driver. (I guess I could test it though, since on my device LED0 and LED1 are used, and this to can be put into bi-colour LED mode.)
I haven't, much to my dismay. The Macchiatobin would have been ideal - the 10G RJ45s have bi-colour on one side and green on the other. It would have been useful if they were wired to support the PHYs bi- colour mode. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!