Re: [PATCH v3 net-next 06/15] net: dsa: add a generic procedure for the flow dissector
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-09-26 20:25:05
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-09-26 20:25:05
On Sat, Sep 26, 2020 at 10:32:06PM +0300, Vladimir Oltean wrote:
For all DSA formats that don't use tail tags, it looks like behind the obscure number crunching they're all doing the same thing: locating the real EtherType behind the DSA tag. Nonetheless, this is not immediately obvious, so create a generic helper for those DSA taggers that put the header before the EtherType. Another assumption for the generic function is that the DSA tags are of equal length on RX and on TX. Prior to the previous patch, this was not true for ocelot and for gswip. The problem was resolved for ocelot, but for gswip it still remains, so that can't use this helper yet. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew