Thread (26 messages) 26 messages, 4 authors, 2020-09-30

Re: [PATCH v3 net-next 02/15] net: dsa: allow drivers to request promiscuous mode on master

From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-09-26 20:22:34

On Sat, Sep 26, 2020 at 10:32:02PM +0300, Vladimir Oltean wrote:
Currently DSA assumes that taggers don't mess with the destination MAC
address of the frames on RX. That is not always the case. Some DSA
headers are placed before the Ethernet header (ocelot), and others
simply mangle random bytes from the destination MAC address (sja1105
with its incl_srcpt option).

Currently the DSA master goes to promiscuous mode automatically when the
slave devices go too (such as when enslaved to a bridge), but in
standalone mode this is a problem that needs to be dealt with.

So give drivers the possibility to signal that their tagging protocol
will get randomly dropped otherwise, and let DSA deal with fixing that.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help