Thread (24 messages) 24 messages, 3 authors, 2020-09-26

Re: [PATCH v2 net-next 02/16] net: dsa: allow drivers to request promiscuous mode on master

From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2020-09-26 17:55:43

On Sat, Sep 26, 2020 at 07:47:00PM +0200, Andrew Lunn wrote:
Hi Vladimir

I actually think this is a property of the tagger, not the DSA
driver. In fact, DSA drivers never handle actual frames, they are all
about the control plane, not the data plane. So i think this bool
should be in the tagger structure, dsa_device_ops.
This is actually a good comment that will simplify my future work a
little bit. I need to add a Kconfig-selectable tagger for the Felix
driver (tag_ocelot.c vs a future tag_ocelot_8021q.c) and, predictably
enough, one tagger needs promisc on master while the other doesn't.

If you have no other comments on this series, I'm thinking about
resending it right away with this change, since I made a big blunder and
the people in Cc on the tagger patches were not actually copied to my
emails, since I have supresscc=all in my .gitconfig.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help