[PATCH v2 net-next 12/16] net: dsa: tag_mtk: use the generic flow dissector procedure
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2020-09-26 17:31:48
Subsystem:
mediatek switch driver, networking [dsa], networking [general], the rest · Maintainers:
Chester A. Unal, Daniel Golle, Andrew Lunn, Vladimir Oltean, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Mediatek switches already account for shifting the frame headers to the right, replace that with a call to the generic flow dissector procedure. Cc: DENG Qingfang <dqfext@gmail.com> Cc: Sean Wang <sean.wang@mediatek.com> Cc: John Crispin <john@phrozen.org> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- net/dsa/tag_mtk.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/net/dsa/tag_mtk.c b/net/dsa/tag_mtk.c
index 2aba17b43e69..7aea20b1d58d 100644
--- a/net/dsa/tag_mtk.c
+++ b/net/dsa/tag_mtk.c@@ -105,19 +105,12 @@ static struct sk_buff *mtk_tag_rcv(struct sk_buff *skb, struct net_device *dev, return skb; } -static void mtk_tag_flow_dissect(const struct sk_buff *skb, __be16 *proto, - int *offset) -{ - *offset = 4; - *proto = ((__be16 *)skb->data)[1]; -} - static const struct dsa_device_ops mtk_netdev_ops = { .name = "mtk", .proto = DSA_TAG_PROTO_MTK, .xmit = mtk_tag_xmit, .rcv = mtk_tag_rcv, - .flow_dissect = mtk_tag_flow_dissect, + .flow_dissect = dsa_tag_generic_flow_dissect, .overhead = MTK_HDR_LEN, };
--
2.25.1