Thread (11 messages) 11 messages, 3 authors, 2020-09-10

[PATCH rdma-next 3/8] RDMA/qedr: Fix use of uninitialized field

flat view
STALE2219d LANDED

From: Michal Kalderon <hidden>
Date: 2020-09-02 17:01:57
Also in: linux-rdma
Subsystem: infiniband subsystem, qlogic ql4xxx rdma driver, the rest · Maintainers: Jason Gunthorpe, Leon Romanovsky, Michal Kalderon, Linus Torvalds

Landed in mainline as a379ad54e55a on 2020-09-11.

dev->attr.page_size_caps was used uninitialized
when setting device attributes

Fixes: ec72fce401c6 ("qedr: Add support for RoCE HW init")
Signed-off-by: Michal Kalderon <redacted>
---
 drivers/infiniband/hw/qedr/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c
index d85f992bac29..8e1365951fb6 100644
--- a/drivers/infiniband/hw/qedr/main.c
+++ b/drivers/infiniband/hw/qedr/main.c
@@ -602,7 +602,7 @@ static int qedr_set_device_attr(struct qedr_dev *dev)
 	qed_attr = dev->ops->rdma_query_device(dev->rdma_ctx);
 
 	/* Part 2 - check capabilities */
-	page_size = ~dev->attr.page_size_caps + 1;
+	page_size = ~qed_attr->page_size_caps + 1;
 	if (page_size > PAGE_SIZE) {
 		DP_ERR(dev,
 		       "Kernel PAGE_SIZE is %ld which is smaller than minimum page size (%d) required by qedr\n",
-- 
2.14.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help