Re: [PATCH] net: qrtr: fix usage of idr in port assignment to socket

On Fri, Aug 14, 2020 at 10:55 PM David Miller [off-list ref] wrote:

From: Necip Fazil Yildiran <redacted>
Date: Fri, 14 Aug 2020 10:10:00 +0000

quoted

diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
index b4c0db0b7d31..52d0707df776 100644
--- a/net/qrtr/qrtr.c
+++ b/net/qrtr/qrtr.c

@@ -693,22 +693,24 @@ static void qrtr_port_remove(struct qrtr_sock *ipc)
 static int qrtr_port_assign(struct qrtr_sock *ipc, int *port)
 {
      int rc;
+     u32 min_port;

Please use reverse christmas tree ordering for local variables.

If Dave's comment is fixed:

Reviewed-by: Dmitry Vyukov <dvyukov@google.com>

(add this tag to the v2 of this patch).

Just in case: "reverse christmas tree" is when variable declarations
are sorted by line length (longest first).