Re: [PATCH] net: qrtr: fix usage of idr in port assignment to socket
From: David Miller <davem@davemloft.net>
Date: 2020-08-14 20:55:30
Also in:
lkml
From: Necip Fazil Yildiran <redacted> Date: Fri, 14 Aug 2020 10:10:00 +0000
quoted hunk ↗ jump to hunk
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index b4c0db0b7d31..52d0707df776 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c@@ -693,22 +693,24 @@ static void qrtr_port_remove(struct qrtr_sock *ipc) static int qrtr_port_assign(struct qrtr_sock *ipc, int *port) { int rc; + u32 min_port;
Please use reverse christmas tree ordering for local variables.