On Mon, Aug 10, 2020 at 09:15:20AM +0100, Edward Cree wrote:

On 09/08/2020 01:29, Guenter Roeck wrote:

quoted

On Mon, Aug 03, 2020 at 09:33:20PM +0100, Edward Cree wrote:

quoted

+		if (EFX_MIN_DMAQ_SIZE % reader->value) {

This is a 64-bit operation (value is 64 bit). Result on 32-bit builds:

ERROR: modpost: "__umoddi3" [drivers/net/ethernet/sfc/sfc.ko] undefined!

Guenter

Yep, kbuild robot already spotted this, and I'm trying to figureout
 the cleanest way to deal with it.
See https://lore.kernel.org/netdev/487d9159-41f8-2757-2e93-01426a527fb5@solarflare.com/ (local)
Any advice would be welcome...

Answered there.

Guenter