Re: [PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at probe time
From: Guenter Roeck <linux@roeck-us.net>
Date: 2020-08-09 00:30:09
On Mon, Aug 03, 2020 at 09:33:20PM +0100, Edward Cree wrote:
quoted hunk ↗ jump to hunk
Several parts of the EF100 architecture are parameterised (to allow varying capabilities on FPGAs according to resource constraints), and these parameters are exposed to the driver through a TLV-encoded region of the BAR. For the most part we either don't care about these values at all or just need to sanity-check them against the driver's assumptions, but there are a number of TSO limits which we record so that we will be able to check against them in the TX path when handling GSO skbs. Signed-off-by: Edward Cree <redacted> --- drivers/net/ethernet/sfc/ef100_nic.c | 216 +++++++++++++++++++++++++++ drivers/net/ethernet/sfc/ef100_nic.h | 4 + 2 files changed, 220 insertions(+)diff --git a/drivers/net/ethernet/sfc/ef100_nic.c b/drivers/net/ethernet/sfc/ef100_nic.c index c2bec2bdbc1f..9b5e4b42fe51 100644 --- a/drivers/net/ethernet/sfc/ef100_nic.c +++ b/drivers/net/ethernet/sfc/ef100_nic.c
[ ... ]
+ if (EFX_MIN_DMAQ_SIZE % reader->value) {This is a 64-bit operation (value is 64 bit). Result on 32-bit builds: ERROR: modpost: "__umoddi3" [drivers/net/ethernet/sfc/sfc.ko] undefined! Guenter