On Mon, Aug 03, 2020 at 05:00:51PM +0200, Andrew Lunn wrote:

On Mon, Aug 03, 2020 at 02:33:56PM +0000, Madalin Bucur (OSS) wrote:

quoted

quoted

-----Original Message-----
From: Andrew Lunn <andrew@lunn.ch>
Sent: 03 August 2020 15:58
To: Madalin Bucur (OSS) <redacted>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>; Vikas Singh
[off-list ref]; f.fainelli@gmail.com; hkallweit1@gmail.com;
netdev@vger.kernel.org; Calvin Johnson (OSS) [off-list ref];
kuldip dwivedi [off-list ref]; Vikas Singh
[off-list ref]
Subject: Re: [PATCH 2/2] net: phy: Associate device node with fixed PHY

quoted

I see you agree that there were and there will be many changes for a

while,

quoted

It's not a complaint, I know hot it works, it's just a decision based on
required effort vs features offered vs user requirements. Lately it's

been

quoted

time consuming to try to fix things in this area.

So the conclusion to all this that you are unwilling to use the
correct API for this, which would be phylink, and the SFP code.  So:

NACK

	Andrew

You've rejected a generic change - ACPI support for fixed link.
The discussion above is just an example of how it could have been (mis-)used.
Are you rejecting the general case or just the particular one?

So far, nobody has corrected me that the MAC is not connected to an
SFP socket. So i see two sorts of abuse going on here:

1) Using a fixed link with a hack to allow 10G. phylink allows 10G
   fixed links without an hacks.

2) Using a fixed link when not even appropriate since phylink should
   be used to control the SFP.

Now, you can do whatever you want in your Vendor Crap tree. But there
is no reason mainline should help you support your vendor crap tree.

+1 for everything above.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!