Thread (7 messages) flat view 7 messages, 5 authors, 2020-07-17

Re: [PATCH net-next] ibmvnic: Increase driver logging

From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-07-16 00:08:23
Also in: linuxppc-dev

On Wed, 15 Jul 2020 18:51:55 -0500 Thomas Falcon wrote:
 	free_netdev(netdev);
 	dev_set_drvdata(&dev->dev, NULL);
+	netdev_info(netdev, "VNIC client device has been successfully removed.\n");
A step too far, perhaps.

In general this patch looks a little questionable IMHO, this amount of
logging output is not commonly seen in drivers. All the the info
messages are just static text, not even carrying any extra information.
In an era of ftrace, and bpftrace, do we really need this?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help