Thread (10 messages) 10 messages, 3 authors, 2020-07-08

Re: [net-next PATCH v3 2/5] net/fsl: store mdiobus fwnode

From: Andy Shevchenko <hidden>
Date: 2020-07-08 19:39:11
Also in: linux-acpi

On Wed, Jul 8, 2020 at 8:35 PM Calvin Johnson
[off-list ref] wrote:
Store fwnode for mdiobus in the bus structure so that it can
later be retrieved and used whenever mdiobus fwnode information
is required.
...
+       if (pdev->dev.fwnode)
But do you need this check?
+               bus->dev.fwnode = pdev->dev.fwnode;
Shouldn't be rather something like dev_fwnode().
And maybe set_primary_fwnode()? I'm not sure about the latter, though.

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help