Re: [net-next PATCH v3 2/5] net/fsl: store mdiobus fwnode
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-07-08 18:55:14
Also in:
linux-acpi
On Wed, Jul 08, 2020 at 11:04:32PM +0530, Calvin Johnson wrote:
quoted hunk ↗ jump to hunk
Store fwnode for mdiobus in the bus structure so that it can later be retrieved and used whenever mdiobus fwnode information is required. Signed-off-by: Calvin Johnson <redacted> --- Changes in v3: None Changes in v2: None drivers/net/ethernet/freescale/xgmac_mdio.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c index 98be51d8b08c..8189c86d5a44 100644 --- a/drivers/net/ethernet/freescale/xgmac_mdio.c +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c@@ -269,6 +269,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev) bus->write = xgmac_mdio_write; bus->parent = &pdev->dev; bus->probe_capabilities = MDIOBUS_C22_C45; + if (pdev->dev.fwnode) + bus->dev.fwnode = pdev->dev.fwnode;
This is pretty fundamental to making this work. In the device tree world, this is setup by of_mdiobus_register(). Maybe we need an fwnode_mdiobus_register(), just to ensure the next device wanting to do ACPI does not forget this? Andrew