Thread (19 messages) flat view 19 messages, 4 authors, 2020-08-10

Re: [PATCH bpf-next 5/5] tools/bpftool: add documentation and bash-completion for `link detach`

From: Song Liu <hidden>
Date: 2020-07-30 21:14:08
Also in: bpf

On Jul 29, 2020, at 4:05 PM, Andrii Nakryiko [off-list ref] wrote:

Add info on link detach sub-command to man page. Add detach to bash-completion
as well.

Signed-off-by: Andrii Nakryiko <redacted>
Acked-by: Song Liu <redacted>

With one nitpick below. 
---
[...]
quoted hunk ↗ jump to hunk
@@ -49,6 +50,13 @@ DESCRIPTION
		  contain a dot character ('.'), which is reserved for future
		  extensions of *bpffs*.

+	**bpftool link detach** *LINK*
+		  Force-detach link *LINK*. BPF link and its underlying BPF
+		  program will stay valid, but they will be detached from the
+		  respective BPF hook and BPF link will transition into
+		  a defunct state until last open file descriptor for that
Shall we say "a defunct state when the last open file descriptor for that..."?

+		  link is closed.
+
	**bpftool link help**
		  Print short help message.
[...]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help