Thread (11 messages) 11 messages, 3 authors, 2020-07-16

RE: [Intel-wired-lan] [PATCH v1 2/5] igbvf: netdev: use generic power management

From: Brown, Aaron F <hidden>
Date: 2020-07-16 18:08:59
Also in: intel-wired-lan, linux-kernel-mentees, lkml

From: Intel-wired-lan <redacted> On Behalf Of
Vaibhav Gupta
Sent: Monday, June 29, 2020 2:30 AM
To: Bjorn Helgaas <helgaas@kernel.org>; Bjorn Helgaas
[off-list ref]; bjorn@helgaas.com; Vaibhav Gupta
[off-list ref]; David S. Miller [off-list ref];
Jakub Kicinski [off-list ref]; Kirsher, Jeffrey T
[off-list ref]
Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>; netdev@vger.kernel.org;
linux-kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org;
skhan@linuxfoundation.org; linux-kernel-mentees@lists.linuxfoundation.org
Subject: [Intel-wired-lan] [PATCH v1 2/5] igbvf: netdev: use generic power
management

Remove legacy PM callbacks and use generic operations. With legacy code,
drivers were responsible for handling PCI PM operations like
pci_save_state(). In generic code, all these hre andled by PCI core.

The generic suspend() and resume() are called at the same point the legacy
ones were called. Thus, it does not affect the normal functioning of the
driver.

__maybe_unused attribute is used with .resume() but not with .suspend(), as
.suspend() is calleb by .shutdown().

Compile-tested only.

Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
---
 drivers/net/ethernet/intel/igbvf/netdev.c | 37 +++++------------------
 1 file changed, 8 insertions(+), 29 deletions(-)
Tested-by: Aaron Brown <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help