RE: [Intel-wired-lan] [PATCH v1 4/5] ixgbevf: use generic power management
From: Bowers, AndrewX <hidden>
Date: 2020-07-01 17:02:17
Also in:
intel-wired-lan, lkml
From: Bowers, AndrewX <hidden>
Date: 2020-07-01 17:02:17
Also in:
intel-wired-lan, lkml
-----Original Message----- From: Intel-wired-lan <redacted> On Behalf Of Vaibhav Gupta Sent: Monday, June 29, 2020 2:30 AM To: Bjorn Helgaas <helgaas@kernel.org>; Bjorn Helgaas [off-list ref]; bjorn@helgaas.com; Vaibhav Gupta [off-list ref]; David S. Miller [off-list ref]; Jakub Kicinski [off-list ref]; Kirsher, Jeffrey T [off-list ref] Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org; skhan@linuxfoundation.org; linux-kernel- mentees@lists.linuxfoundation.org Subject: [Intel-wired-lan] [PATCH v1 4/5] ixgbevf: use generic power management With legacy PM, drivers themselves were responsible for managing the device's power states and takes care of register states. After upgrading to the generic structure, PCI core will take care of required tasks and drivers should do only device-specific operations. The driver was invoking PCI helper functions like pci_save/restore_state(), and pci_enable/disable_device(), which is not recommended. Compile-tested only. Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> --- .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 44 +++++-------------- 1 file changed, 10 insertions(+), 34 deletions(-)
Tested-by: Andrew Bowers <redacted>