Thread (35 messages) 35 messages, 7 authors, 2020-07-15

Re: [PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage

From: Mark Brown <broonie@kernel.org>
Date: 2020-07-01 20:39:26
Also in: linux-block, linux-clk, linux-doc, linux-ide, linux-mm, linux-spi, linux-wireless, lkml

On Fri, Jun 19, 2020 at 08:29:59PM -0700, Kees Cook wrote:
Using uninitialized_var() is dangerous as it papers over real bugs[1]
(or can in the future), and suppresses unrelated compiler warnings (e.g.
"unused variable"). If the compiler thinks it is uninitialized, either
simply initialize the variable or make compiler changes. As a precursor
to removing[2] this[3] macro[4], just remove this variable since it was
actually unused:
Please copy maintainers on patches :(

Acked-by: Mark Brown <broonie@kernel.org>

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help