Re: [RFC PATCH 3/9] net: dsa: hellcreek: Add PTP clock support
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-06-18 17:23:13
Also in:
linux-devicetree
quoted hunk ↗ jump to hunk
+static u64 __hellcreek_ptp_clock_read(struct hellcreek *hellcreek) +{ + u16 nsl, nsh, secl, secm, sech; + + /* Take a snapshot */ + hellcreek_ptp_write(hellcreek, PR_COMMAND_C_SS, PR_COMMAND_C); + + /* The time of the day is saved as 96 bits. However, due to hardware + * limitations the seconds are not or only partly kept in the PTP + * core. That's why only the nanoseconds are used and the seconds are + * tracked in software. Anyway due to internal locking all five + * registers should be read. + */ + sech = hellcreek_ptp_read(hellcreek, PR_SS_SYNC_DATA_C); + secm = hellcreek_ptp_read(hellcreek, PR_SS_SYNC_DATA_C); + secl = hellcreek_ptp_read(hellcreek, PR_SS_SYNC_DATA_C); + nsh = hellcreek_ptp_read(hellcreek, PR_SS_SYNC_DATA_C); + nsl = hellcreek_ptp_read(hellcreek, PR_SS_SYNC_DATA_C); + + return (u64)nsl | ((u64)nsh << 16);
Hi Kurt What are the hardware limitations? There seems to be 48 bits for seconds? That allows for 8925104 years?
quoted hunk ↗ jump to hunk
+static u64 __hellcreek_ptp_gettime(struct hellcreek *hellcreek) +{ + u64 ns; + + ns = __hellcreek_ptp_clock_read(hellcreek); + if (ns < hellcreek->last_ts) + hellcreek->seconds++; + hellcreek->last_ts = ns; + ns += hellcreek->seconds * NSEC_PER_SEC;
So the assumption is, this gets called at least once per second. And if that does not happen, there is no recovery. The second is lost. I'm just wondering if there is something more robust using what the hardware does provide, even if the hardware is not perfect. Andrew