Re: [PATCH v2] SUNRPC: Add missing definition of ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE

From
Bruce Fields <hidden>
Date
2020-06-25 20:40:32
Also in
linux-nfs, linuxppc-dev, lkml
Reply to
Chuck Lever, 2020-06-15
On Mon, Jun 15, 2020 at 08:33:40AM -0400, Chuck Lever wrote:
quoted
On Jun 15, 2020, at 2:25 AM, Christophe Leroy [off-list ref] wrote:

Even if that's only a warning, not including asm/cacheflush.h
leads to svc_flush_bvec() being empty allthough powerpc defines
ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE.

 CC      net/sunrpc/svcsock.o
net/sunrpc/svcsock.c:227:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined [-Wundef]
#if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE
    ^

Include linux/highmem.h so that asm/cacheflush.h will be included.

Reported-by: Christophe Leroy <redacted>
Reported-by: kernel test robot <redacted>
Cc: Chuck Lever <redacted>
Fixes: ca07eda33e01 ("SUNRPC: Refactor svc_recvfrom()")
Signed-off-by: Christophe Leroy <redacted>
LGTM.

Acked-by: Chuck Lever <redacted>
Thanks, applying for 5.8.--b.
Thread (3 messages) 3 messages, 3 authors, last reply 2020-06-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help