Re: [PATCH v2] SUNRPC: Add missing definition of ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE
From: Chuck Lever <chuck.lever@oracle.com>
Date: 2020-06-15 12:34:19
Also in:
linux-nfs, linuxppc-dev, lkml
On Jun 15, 2020, at 2:25 AM, Christophe Leroy [off-list ref] wrote:
Even if that's only a warning, not including asm/cacheflush.h
leads to svc_flush_bvec() being empty allthough powerpc defines
ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE.
CC net/sunrpc/svcsock.o
net/sunrpc/svcsock.c:227:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined [-Wundef]
#if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE
^
Include linux/highmem.h so that asm/cacheflush.h will be included.
Reported-by: Christophe Leroy <redacted>
Reported-by: kernel test robot <redacted>
Cc: Chuck Lever <chuck.lever@oracle.com>
Fixes: ca07eda33e01 ("SUNRPC: Refactor svc_recvfrom()")
Signed-off-by: Christophe Leroy <redacted>LGTM. Acked-by: Chuck Lever <chuck.lever@oracle.com>
quoted hunk ↗ jump to hunk
--- v2: Use linux/highmem.h instead of asm/cacheflush.sh Signed-off-by: Christophe Leroy <redacted> --- net/sunrpc/svcsock.c | 1 + 1 file changed, 1 insertion(+)diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 5c4ec9386f81..c537272f9c7e 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c@@ -44,6 +44,7 @@#include <net/tcp.h> #include <net/tcp_states.h> #include <linux/uaccess.h> +#include <linux/highmem.h> #include <asm/ioctls.h> #include <linux/sunrpc/types.h> -- 2.25.0
-- Chuck Lever