Thread (49 messages) flat view 49 messages, 7 authors, 2020-06-24

Re: [PATCH 05/15] net: phy: reset the PHY even if probe() is not implemented

From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-06-22 13:16:47
Also in: linux-devicetree, lkml

On Mon, Jun 22, 2020 at 11:37:34AM +0200, Bartosz Golaszewski wrote:
From: Bartosz Golaszewski <redacted>

Currently we only call phy_device_reset() if the PHY driver implements
the probe() callback. This is not mandatory and many drivers (e.g.
realtek) don't need probe() for most devices but still can have reset
GPIOs defined. There's no reason to depend on the presence of probe()
here so pull the reset code out of the if clause.

Signed-off-by: Bartosz Golaszewski <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help