On Thu, Jun 04, 2020 at 11:39:05PM +0200, Thomas Gleixner wrote:
Kees Cook [off-list ref] writes:
quoted
quoted
quoted
-#define NODE_NOT_IN_PAGE_FLAGS
+#define NODE_NOT_IN_PAGE_FLAGS 1
but if we ever lose the 1 then the above will silently compile the code
within the IS_ENABLED() section out.
That's true, yes. I considered two other ways to do this:
1) smallest patch, but more #ifdef:
2) medium size, weird style:
and 3 is what I sent: biggest, but removes #ifdef
Any preference?
From a readbility POV I surely prefer #3. i"m just wary. Add a big fat
comment to the define might mitigate that, hmm?
Sure! I'll add it.
--
Kees Cook