Re: [PATCH 01/10] x86/mm/numa: Remove uninitialized_var() usage

Kees Cook [off-list ref] writes:

quoted

quoted

-#define NODE_NOT_IN_PAGE_FLAGS
+#define NODE_NOT_IN_PAGE_FLAGS 1

but if we ever lose the 1 then the above will silently compile the code
within the IS_ENABLED() section out.

That's true, yes. I considered two other ways to do this:

1) smallest patch, but more #ifdef:
2) medium size, weird style:

and 3 is what I sent: biggest, but removes #ifdef

Any preference?

From a readbility POV I surely prefer #3. i"m just wary. Add a big fat
comment to the define might mitigate that, hmm?

Thanks,

        tglx