Re: [PATCH v2 09/15] qed: use new module_firmware_crashed()
From: Rafael Aquini <hidden>
Date: 2020-05-16 04:10:49
Also in:
lkml
On Fri, May 15, 2020 at 09:28:40PM +0000, Luis Chamberlain wrote:
quoted hunk ↗ jump to hunk
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Ariel Elior <redacted> Cc: GR-everest-linux-l2@marvell.com Reviewed-by: Igor Russkikh <redacted> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- drivers/net/ethernet/qlogic/qed/qed_mcp.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c index 9624616806e7..aea200d465ef 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c +++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c@@ -566,6 +566,7 @@ _qed_mcp_cmd_and_union(struct qed_hwfn *p_hwfn, DP_NOTICE(p_hwfn, "The MFW failed to respond to command 0x%08x [param 0x%08x].\n", p_mb_params->cmd, p_mb_params->param); + module_firmware_crashed(); qed_mcp_print_cpu_info(p_hwfn, p_ptt); spin_lock_bh(&p_hwfn->mcp_info->cmd_lock);-- 2.26.2
Acked-by: Rafael Aquini <redacted>