Re: [PATCH v2 05/15] bna: use new module_firmware_crashed()
From: Rafael Aquini <hidden>
Date: 2020-05-16 04:07:28
Also in:
lkml
On Fri, May 15, 2020 at 09:28:36PM +0000, Luis Chamberlain wrote:
quoted hunk ↗ jump to hunk
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Rasesh Mody <rmody@marvell.com> Cc: Sudarsana Kalluru <skalluru@marvell.com> Cc: GR-Linux-NIC-Dev@marvell.com Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c index e17bfc87da90..b3f44a912574 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c@@ -927,6 +927,7 @@ bfa_iocpf_sm_disabled(struct bfa_iocpf *iocpf, enum iocpf_event event) static void bfa_iocpf_sm_initfail_sync_entry(struct bfa_iocpf *iocpf) { + module_firmware_crashed(); bfa_nw_ioc_debug_save_ftrc(iocpf->ioc); bfa_ioc_hw_sem_get(iocpf->ioc); }-- 2.26.2
Acked-by: Rafael Aquini <redacted>