Re: [PATCH net-next 11/11] net: dsa: ocelot: introduce driver for Seville VSC9953 switch

From
Vladimir Oltean <olteanv@gmail.com>
Date
2020-05-29 15:43:02
Reply to
Alexandre Belloni, 2020-05-29
On Fri, 29 May 2020 at 12:03, Alexandre Belloni
[off-list ref] wrote:
On 29/05/2020 11:30:43+0300, Vladimir Oltean wrote:
quoted
quoted
As ocelot can be used in a DSA configuration (even if it is not
implemented yet), I don't think this would be correct. From my point of
view, felix and seville are part of the ocelot family.
In this case, there would be a third driver in
drivers/net/dsa/ocelot/ocelot_vsc7511.c which uses the intermediate
felix_switch_ops from felix.c to access the ocelot core
implementation. Unless you have better naming suggestions?
I don't. Maybe felix.c should have been ocelot.c from the beginning but
honestly, it doesn't matter that much.
Technically Seville is not part of the Ocelot family but part of
Serval, but then again, it's just a marketing name, so it doesn't
really mean anything..
I am a bit reluctant to rename the DSA driver ops to "ocelot", since
it would be even more confusing for everyone to have a function
ocelot_dsa_set_ageing_time that calls ocelot_set_ageing_time. At least
this way, there's going to be some learning curve figuring out that
felix is an umbrella term for DSA ops, but there will be more naming
predictability. (at least that's how I see it)
BTW, maybe we should merge the VITESSE FELIX ETHERNET SWITCH DRIVER and
MICROSEMI ETHERNET SWITCH DRIVER entries in MAINTAINERS. You do much
more work in drivers/net/ethernet/mscc/ than I currently do.
How would you see the merged MAINTAINERS entry? Something like this?

MICROSEMI ETHERNET SWITCH DRIVER
M:    Alexandre Belloni [off-list ref]
M:    Microchip Linux Driver Support [off-list ref]
M:    Vladimir Oltean [off-list ref]
M:    Claudiu Manoil [off-list ref]
L:    netdev@vger.kernel.org
S:    Maintained
F:    include/soc/mscc/ocelot*
F:    drivers/net/ethernet/mscc/
F:    drivers/net/dsa/ocelot/*
F:    net/dsa/tag_ocelot.c

Any takers from Microchip, or is the internal mailing list enough?
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Thread (31 messages) 31 messages, 5 authors, last reply 2020-05-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help