Re: [PATCH net-next 11/11] net: dsa: ocelot: introduce driver for Seville VSC9953 switch

From
Andrew Lunn <andrew@lunn.ch>
Date
2020-05-28 21:56:30
Reply to
Vladimir Oltean, 2020-05-27
Extending the Felix driver to probe a PCI as well as a platform device
would have introduced unnecessary complexity. The 'meat' of both drivers
is in drivers/net/ethernet/mscc/ocelot*.c anyway, so let's just
duplicate the Felix driver, s/Felix/Seville/, and define the low-level
bits in seville_vsc9953.c.
Hi Vladimir

That has resulted in a lot of duplicated code.

Is there an overall family name for these switch?

Could you add foo_set_ageing_time() with both felix and saville share?

      Andrew
Thread (31 messages) 31 messages, 5 authors, last reply 2020-05-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help