Re: [PATCH net-next v3 06/10] net: ethtool: Add infrastructure for reporting cable test results
From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-05-10 18:39:52
From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-05-10 18:39:52
On Sun, 10 May 2020 20:22:52 +0200 Andrew Lunn wrote:
quoted
Sorry Andrew, would you mind doing one more quick spin? :(No problem.
Thanks!
quoted
More importantly we should not use the ENOTSUPP error code, AFAIU it's for NFS, it's not a standard error code and user space struggles to translate it with strerror(). Would you mind replacing all ENOTSUPPs with EOPNOTSUPPs?O.K. Would it be worth getting checkpatch warning about this?
Good point. I feel like I already had a patch for it once, it must have gotten lost when I was changing jobs. I'll take care of it.