Re: [PATCH net-next v3 06/10] net: ethtool: Add infrastructure for reporting cable test results
From: Michal Kubecek <hidden>
Date: 2020-05-10 15:12:29
From: Michal Kubecek <hidden>
Date: 2020-05-10 15:12:29
On Sat, May 09, 2020 at 06:28:47PM +0200, Andrew Lunn wrote:
Provide infrastructure for PHY drivers to report the cable test results. A netlink skb is associated to the phydev. Helpers will be added which can add results to this skb. Once the test has finished the results are sent to user space. When netlink ethtool is not part of the kernel configuration stubs are provided. It is also impossible to trigger a cable test, so the error code returned by the alloc function is of no consequence. v2: Include the status complete in the netlink notification message Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Michal Kubecek <redacted> It seems you applied the changes to ethnl_cable_test_alloc() suggested in v2 review as part of patch 7 rather than here. I don't think it's necessary to fix that unless there is some actual problem that would require a resubmit. Michal