Thread (12 messages) read the whole thread 12 messages, 3 authors, 2020-03-20

Re: [PATCH] bpf: explicitly memset the bpf_attr structure

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2020-03-20 20:07:32
Also in: bpf, lkml

On 3/20/20 10:48 AM, Greg Kroah-Hartman wrote:
For the bpf syscall, we are relying on the compiler to properly zero out
the bpf_attr union that we copy userspace data into.  Unfortunately that
doesn't always work properly, padding and other oddities might not be
correctly zeroed, and in some tests odd things have been found when the
stack is pre-initialized to other values.

Fix this by explicitly memsetting the structure to 0 before using it.

Reported-by: Maciej Żenczykowski <redacted>
Reported-by: John Stultz <redacted>
Reported-by: Alexander Potapenko <glider@google.com>
Reported-by: Alistair Delva <redacted>
Cc: stable <redacted>
Link: https://android-review.googlesource.com/c/kernel/common/+/1235490
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help