On Wed, Mar 18, 2020 at 10:28:48AM +0100, Fuzzey, Martin wrote:

Hi Andrew,

On Wed, 18 Mar 2020 at 10:17, Andrew Lunn [off-list ref] wrote:

quoted

You should not be putting registers and values into device tree.

The regmap is fine. But could you add the register and the bit to
fec_devtype[IMX6SX_FEC], fec_devtype[IMX6UL_FEC], etc.

If that's the consensus I can do it that way.

But I should point out that there is already a precedent in mainline for this:

Documentation/devicetree/bindings/net/can/fsl-flexcan.txt

Hi Martin

And there are probably hundreds of emails saying don't do this.

	Andrew