Thread (14 messages) 14 messages, 3 authors, 2020-03-18

Re: [PATCH 3/4] dt-bindings: fec: document the new fsl,stop-mode property

From: Fuzzey, Martin <hidden>
Date: 2020-03-18 09:29:03
Also in: linux-devicetree, lkml

Hi Andrew,

On Wed, 18 Mar 2020 at 10:17, Andrew Lunn [off-list ref] wrote:
You should not be putting registers and values into device tree.

The regmap is fine. But could you add the register and the bit to
fec_devtype[IMX6SX_FEC], fec_devtype[IMX6UL_FEC], etc.
If that's the consensus I can do it that way.

But I should point out that there is already a precedent in mainline for this:

Documentation/devicetree/bindings/net/can/fsl-flexcan.txt

Regards,

Martin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help