Re: [PATCH net-next v3 1/9] sysfs: add sysfs_file_change_owner{_by_name}()

From
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date
2020-02-20 11:11:32
Also in
linux-pm, lkml
Reply to
Christian Brauner, 2020-02-18
On Tue, Feb 18, 2020 at 05:29:35PM +0100, Christian Brauner wrote:
Add helpers to change the owner of a sysfs files.
This function will be used to correctly account for kobject ownership
changes, e.g. when moving network devices between network namespaces.

Signed-off-by: Christian Brauner <redacted>
---
/* v2 */
-  Greg Kroah-Hartman [off-list ref]:
   - Better naming for sysfs_file_change_owner() to reflect the fact that it
     can be used to change the owner of the kobject itself by passing NULL as
     argument.
- Christian Brauner [off-list ref]:
  - Split sysfs_file_change_owner() into two helpers sysfs_change_owner() and
    sysfs_change_owner_by_name(). The former changes the owner of the kobject
    itself, the latter the owner of the kobject looked up via the name
    argument.

/* v3 */
-  Greg Kroah-Hartman [off-list ref]:
   - Add explicit uid/gid parameters.
Looks much better, thanks for doing these changes.  I'll review the
whole series now...

greg k-h
Thread (28 messages) 28 messages, 4 authors, last reply 2020-02-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help