Re: [PATCH devicetree 3/4] arm64: dts: fsl: ls1028a: add node for Felix switch
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-02-17 15:29:22
Also in:
linux-devicetree, lkml
Hi Vladimir
quoted hunk ↗ jump to hunk
+ /* Internal port with DSA tagging */ + mscc_felix_port4: port@4 { + reg = <4>; + phy-mode = "gmii";
Is it really using gmii? Often in SoC connections use something else, and phy-mode = "internal" is more appropriate.
quoted hunk ↗ jump to hunk
+ ethernet = <&enetc_port2>; + + fixed-link { + speed = <2500>; + full-duplex; + };
gmii and 2500 also don't really go together.
Andrew