Re: [PATCH net-next 2/2] net: switch to using PHY_INTERFACE_MODE_10GBASER rather than 10GKR
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-01-03 20:25:11
Also in:
linux-doc
quoted hunk ↗ jump to hunk
For Marvell mvpp2, we detect 10GBASE-KR, and rewrite it to 10GBASE-R for compatibility with existing DT - this is the only network driver at present that makes use of PHY_INTERFACE_MODE_10GKR. Signed-off-by: Russell King <redacted>@@ -5247,6 +5247,9 @@ static int mvpp2_port_probe(struct platform_device *pdev, goto err_free_netdev; } + if (phy_mode == PHY_INTERFACE_MODE_10GKR) + phy_mode = PHY_INTERFACE_MODE_10GBASER;
Hi Russell
Maybe consider adding a comment here, or suggest readers to read the
commit message of the patch that added these two lines to get the full
story.
Apart from that:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew