RE: [PATCH bpf-next v2 06/11] bpf, sockmap: Don't set up sockmap progs for listening sockets
From: John Fastabend <john.fastabend@gmail.com>
Date: 2020-01-12 01:07:59
Also in:
bpf
From: John Fastabend <john.fastabend@gmail.com>
Date: 2020-01-12 01:07:59
Also in:
bpf
John Fastabend wrote:
Jakub Sitnicki wrote:quoted
Now that sockmap can hold listening sockets, when setting up the psock we will (i) grab references to verdict/parser progs, and (2) override socket upcalls sk_data_ready and sk_write_space. We cannot redirect to listening sockets so we don't need to link the socket to the BPF progs, but more importantly we don't want the listening socket to have overridden upcalls because they would get inherited by child sockets cloned from it. Introduce a separate initialization path for listening sockets that does not change the upcalls and ignores the BPF progs. Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com> --- net/core/sock_map.c | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-)Any reason only support for sock_map types are added? We can also support sock_hash I presume? Could be a follow up patch I guess but if its not too much trouble would be worth adding now vs trying to detect at run time later. I think it should be as simple as using similar logic as below in sock_hash_update_common Thanks.
After running through the other patches I think its probably OK to do hash support as a follow up. Up to you.