Thread (49 messages) 49 messages, 5 authors, 2020-01-21

RE: [PATCH bpf-next v2 01/11] bpf, sk_msg: Don't reset saved sock proto on restore

From: John Fastabend <john.fastabend@gmail.com>
Date: 2020-01-11 22:58:21
Also in: bpf

Jakub Sitnicki wrote:
There is no need to reset psock->sk_proto when restoring socket protocol
callbacks (sk->sk_prot). The psock is about to get detached from the sock
and eventually destroyed.

No harm done if we restore the protocol callbacks twice, while it makes
reasoning about psock state easier, that is once psock was initialized, we
can assume psock->sk_proto is set.

Also, we don't need a fallback for when socket is not using ULP.
tcp_update_ulp already does this for us.

Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
---
Acked-by: John Fastabend <john.fastabend@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help