Thread (26 messages) flat view 26 messages, 5 authors, 2020-01-24

Re: [PATCH bpf 1/4] selftests: bpf: use a temporary file in test_sockmap

From: Jakub Sitnicki <jakub@cloudflare.com>
Date: 2020-01-24 09:20:24
Also in: bpf, linux-kselftest, lkml

On Thu, Jan 23, 2020 at 05:59 PM CET, Lorenz Bauer wrote:
quoted hunk ↗ jump to hunk
Use a proper temporary file for sendpage tests. This means that running
the tests doesn't clutter the working directory, and allows running the
test on read-only filesystems.

Signed-off-by: Lorenz Bauer <redacted>
---
 tools/testing/selftests/bpf/test_sockmap.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c
index 4a851513c842..779e11da979c 100644
--- a/tools/testing/selftests/bpf/test_sockmap.c
+++ b/tools/testing/selftests/bpf/test_sockmap.c
@@ -331,7 +331,7 @@ static int msg_loop_sendpage(int fd, int iov_length, int cnt,
 	FILE *file;
 	int i, fp;

-	file = fopen(".sendpage_tst.tmp", "w+");
+	file = tmpfile();
 	if (!file) {
 		perror("create file for sendpage");
 		return 1;
memfd_create() would be an alternative that doesn't clutter anything.

[...]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help