Thread (26 messages) flat view 26 messages, 5 authors, 2020-01-24

Re: [PATCH bpf 4/4] selftests: bpf: reset global state between reuseport test runs

From: Martin Lau <hidden>
Date: 2020-01-23 17:57:07
Also in: bpf, linux-kselftest, lkml

On Thu, Jan 23, 2020 at 04:59:33PM +0000, Lorenz Bauer wrote:
Currently, there is a lot of false positives if a single reuseport test
fails. This is because expected_results and the result map are not cleared.
Ah, right.  An earlier test failure has ripple effect on the following tests.

I notice another embarrassing typo.  Can you also make this change in this fix?

-static enum result expected_results[NR_RESULTS];
+static __u32 expected_results[NR_RESULTS];
Zero both after individual test runs, which fixes the mentioned false
positives.
Thanks for the fix!

Acked-by: Martin KaFai Lau <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help