On Tue, Jan 21, 2020 at 03:50:53PM +0000, Stefan Hajnoczi wrote:

What should vsock_dev_do_ioctl() IOCTL_VM_SOCKETS_GET_LOCAL_CID return?
The answer is probably dependent on the caller's network namespace.

Right, and I'm not handling this case. I'll fix!

Ultimately we may need per-namespace transports.  Imagine assigning a
G2H transport to a specific network namespace.

Agree.

vsock_stream_connect() needs to be namespace-aware so that other
namespaces cannot use the G2H transport to send a connection
establishment packet.

Right, maybe I can change the vsock_assign_transport() to check if a
transport can be assigned to a socket, checking the namespace.

I'll send a v2 handling these cases and implementing the Michael's idea
about /dev/vhost-vsock-netns

Thanks,
Stefano