Re: [PATCH v4 02/17] octeontx2-pf: Mailbox communication with AF

On Thu, 23 Jan 2020 00:57:22 +0530, Sunil Kovvuri wrote:

quoted

I'm slightly concerned about the use of non-iomem helpers like memset
and memcpy on what I understand to be IOMEM, and the lack of memory
barriers. But then again, I don't know much about iomem_wc(), is this
code definitely correct from memory ordering perspective?
(The memory barrier in otx2_mbox_msg_send() should probably be just
wmb(), syncing with HW is unrelated with SMP.)  

The mailbox region is a normal memory which is exposed to two devices
via PCI BARs.
And the writeq() call (to trigger IRQ) inside otx2_mbox_msg_send() has a wmb().

Oka, fine, if it works it works, I guess.