[RFC PATCH v2 3/8] net: phylink: call mac_an_restart for SGMII/QSGMII inband interfaces too
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2019-12-17 22:19:46
Subsystem:
ethernet phy library, networking drivers, sff/sfp/sfp+ module support, the rest · Maintainers:
Andrew Lunn, Heiner Kallweit, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Russell King, Linus Torvalds
From: Vladimir Oltean <vladimir.oltean@nxp.com> It doesn't quite make sense why restarting the AN process should be unique to 802.3z (1000Base-X) modes. It is valid to put an SGMII PCS in in-band AN mode, therefore also make PHYLINK re-trigger an auto-negotiation if needed. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- drivers/net/phy/phylink.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index f9ad794cfee1..0e563c22d725 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c@@ -358,7 +358,9 @@ static void phylink_mac_config_up(struct phylink *pl, static void phylink_mac_an_restart(struct phylink *pl) { if (pl->link_config.an_enabled && - phy_interface_mode_is_8023z(pl->link_config.interface)) + (phy_interface_mode_is_8023z(pl->link_config.interface) || + pl->link_config.interface == PHY_INTERFACE_MODE_SGMII || + pl->link_config.interface == PHY_INTERFACE_MODE_QSGMII)) pl->ops->mac_an_restart(pl->config); }
--
2.7.4