Thread (47 messages) 47 messages, 9 authors, 2019-10-02

Re: [PATCH bpf-next 2/6] libbpf: move bpf_helpers.h, bpf_endian.h into libbpf

From: John Fastabend <john.fastabend@gmail.com>
Date: 2019-10-01 19:18:20
Also in: bpf

Toke Høiland-Jørgensen wrote:
quoted
+struct bpf_map_def {
+	unsigned int type;
+	unsigned int key_size;
+	unsigned int value_size;
+	unsigned int max_entries;
+	unsigned int map_flags;
+	unsigned int inner_map_idx;
+	unsigned int numa_node;
+};
Didn't we agree on no new bpf_map_def ABI in libbpf, and that all
additions should be BTF-based?

-Toke
We use libbpf on pre BTF kernels so in this case I think it makes
sense to add these fields. Having inner_map_idx there should allow
us to remove some other things we have sitting around.

.John
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help